[webkit-reviews] review denied: [Bug 212415] WebKit Crashes when SVG Filter Logging is Turned On : [Attachment 400345] Patch

[bugzilla-daemon at webkit.org]

Simon Fraser (smfr) <simon.fraser at apple.com> has denied guowei_yang at apple.com's
request for review:
Bug 212415: WebKit Crashes when SVG Filter Logging is Turned On
https://bugs.webkit.org/show_bug.cgi?id=212415

Attachment 400345: Patch

https://bugs.webkit.org/attachment.cgi?id=400345&action=review




--- Comment #4 from Simon Fraser (smfr) <simon.fraser at apple.com> ---
Comment on attachment 400345
  --> https://bugs.webkit.org/attachment.cgi?id=400345
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=400345&action=review

> Source/WebCore/platform/graphics/filters/FilterEffect.cpp:269
> -    LOG_WITH_STREAM(Filters, stream << "FilterEffect " << filterName() << "
" << this << " imageBufferResult(). Existing image buffer " <<
m_imageBufferResult.get() <<  " m_premultipliedImageResult " <<
m_premultipliedImageResult->data() << " m_unmultipliedImageResult " <<
m_unmultipliedImageResult->data());
> +    LOG_WITH_STREAM(Filters, stream << "FilterEffect " << filterName() << "
" << this << " imageBufferResult(). Existing image buffer " <<
m_imageBufferResult.get());

You want to do:
LOG_WITH_STREAM(Filters, stream << "FilterEffect " << filterName() << " " <<
this << " imageBufferResult(). Existing image buffer " <<
m_imageBufferResult.get() << " m_premultipliedImageResult " <<
(m_premultipliedImageResult  ? m_premultipliedImageResult->data() : nullptr) <<
" m_unmultipliedImageResult " << (m_unmultipliedImageResult  ?
m_unmultipliedImageResult->data() : nullptr));