[webkit-reviews] review granted: [Bug 212411] [Cocoa] Adopt read-only mode for preferences in the WebContent process : [Attachment 400343] Patch

[bugzilla-daemon at webkit.org]

Darin Adler <darin at apple.com> has granted Per Arne Vollan <pvollan at apple.com>'s
request for review:
Bug 212411: [Cocoa] Adopt read-only mode for preferences in the WebContent
process
https://bugs.webkit.org/show_bug.cgi?id=212411

Attachment 400343: Patch

https://bugs.webkit.org/attachment.cgi?id=400343&action=review




--- Comment #3 from Darin Adler <darin at apple.com> ---
Comment on attachment 400343
  --> https://bugs.webkit.org/attachment.cgi?id=400343
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=400343&action=review

> Source/WTF/wtf/PlatformHave.h:640
> +#if (PLATFORM(MAC) && __MAC_OS_X_VERSION_MIN_REQUIRED >= 101600) ||
(PLATFORM(IOS_FAMILY) && __IPHONE_OS_VERSION_MIN_REQUIRED >= 140000)
> +#define HAVE_CFPREFS_READONLY_SPI 1
> +#endif

This has the common mistake that Tim Horton alerted us to: checking IOS_FAMILY
and then only checking __IPHONE_OS_VERSION_MIN_REQUIRED, which is frozen at a
lower value on watchOS and tVOS. If our intent is to include only iOS itself,
then please use PLATFORM(IOS), or add the relevant version checking for watchOS
and tvOS. HAVE_CFNETWORK_METRICS_CONNECTION_PROPERTIES is one example of doing
this correctly.