[webkit-reviews] review granted: [Bug 212402] RealtimeIncomingVideoSourceCocoa::OnFrame should use video frame timestamp : [Attachment 400320] Patch

[bugzilla-daemon at webkit.org]

Eric Carlson <eric.carlson at apple.com> has granted youenn fablet
<youennf at gmail.com>'s request for review:
Bug 212402: RealtimeIncomingVideoSourceCocoa::OnFrame should use video frame
timestamp
https://bugs.webkit.org/show_bug.cgi?id=212402

Attachment 400320: Patch

https://bugs.webkit.org/attachment.cgi?id=400320&action=review




--- Comment #3 from Eric Carlson <eric.carlson at apple.com> ---
Comment on attachment 400320
  --> https://bugs.webkit.org/attachment.cgi?id=400320
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=400320&action=review

Nice simplification!

>
Source/WebCore/platform/graphics/avfoundation/objc/LocalSampleBufferDisplayLaye
r.mm:331
>      while (!m_pendingVideoSampleQueue.isEmpty()) {
> -	   if (m_pendingVideoSampleQueue.first()->decodeTime() > now)
> +	   auto presentationTime =
m_pendingVideoSampleQueue.first()->presentationTime();
> +	   if (presentationTime.isValid() && presentationTime > now)
>	       break;
>	   m_pendingVideoSampleQueue.removeFirst();

Will this do the right thing with 'display immediately' samples?