[webkit-reviews] review granted: [Bug 212338] [WPE] Avoid possible WTR event timing going back in time and fix conversion from s to ms : [Attachment 400303] Updated patch initializing m_time to MonotonicTime::now

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Wed May 27 06:07:11 PDT 2020


Michael Catanzaro <mcatanzaro at gnome.org> has granted Lauro Moura
<lmoura at igalia.com>'s request for review:
Bug 212338: [WPE] Avoid possible WTR event timing going back in time and fix
conversion from s to ms
https://bugs.webkit.org/show_bug.cgi?id=212338

Attachment 400303: Updated patch initializing m_time to MonotonicTime::now

https://bugs.webkit.org/attachment.cgi?id=400303&action=review




--- Comment #16 from Michael Catanzaro <mcatanzaro at gnome.org> ---
Comment on attachment 400303
  --> https://bugs.webkit.org/attachment.cgi?id=400303
Updated patch initializing m_time to MonotonicTime::now

You'll need to add a failure expectation for iOS-wk2:

---
/Volumes/Data/worker/iOS-13-Simulator-WK2-Tests-EWS/build/layout-test-results/f
ast/events/monotonic-event-time-expected.txt
+++
/Volumes/Data/worker/iOS-13-Simulator-WK2-Tests-EWS/build/layout-test-results/f
ast/events/monotonic-event-time-actual.txt
@@ -3,10 +3,6 @@
 On success, you will see a series of "PASS" messages, followed by "TEST
COMPLETE".


-PASS lastTimeStamp < event.timeStamp is true
-PASS lastTimeStamp < event.timeStamp is true
-PASS lastTimeStamp < event.timeStamp is true
-PASS lastTimeStamp < event.timeStamp is true
 PASS successfullyParsed is true

 TEST COMPLETE


More information about the webkit-reviews mailing list