[webkit-reviews] review granted: [Bug 212389] Sort PlatformEnableCocoa.h and add definitions for the simple cases from FeatureDefines.xcconfig : [Attachment 400287] Patch

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Tue May 26 21:25:09 PDT 2020


Anders Carlsson <andersca at apple.com> has granted Darin Adler
<darin at apple.com>'s request for review:
Bug 212389: Sort PlatformEnableCocoa.h and add definitions for the simple cases
from FeatureDefines.xcconfig
https://bugs.webkit.org/show_bug.cgi?id=212389

Attachment 400287: Patch

https://bugs.webkit.org/attachment.cgi?id=400287&action=review




--- Comment #2 from Anders Carlsson <andersca at apple.com> ---
Comment on attachment 400287
  --> https://bugs.webkit.org/attachment.cgi?id=400287
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=400287&action=review

> Source/WTF/wtf/PlatformEnableCocoa.h:39
> +/* Please keep the following in alphabetical order so we can notice
duplicates. */

Why not use // C++ style comments?


More information about the webkit-reviews mailing list