[webkit-reviews] review granted: [Bug 212378] IteratorClose should suppress GetMethod errors : [Attachment 400252] Patch
bugzilla-daemon at webkit.org
bugzilla-daemon at webkit.org
Tue May 26 14:43:09 PDT 2020
Keith Miller <keith_miller at apple.com> has granted Alexey Shvayka
<shvaikalesh at gmail.com>'s request for review:
Bug 212378: IteratorClose should suppress GetMethod errors
https://bugs.webkit.org/show_bug.cgi?id=212378
Attachment 400252: Patch
https://bugs.webkit.org/attachment.cgi?id=400252&action=review
--- Comment #2 from Keith Miller <keith_miller at apple.com> ---
Comment on attachment 400252
--> https://bugs.webkit.org/attachment.cgi?id=400252
Patch
r=me.
RE, Your offline question about whether emitIteratorGenericClose should take
the label. I don't think it's too important either way and I could imagine
other places where you don't want the label. I'd leave it as is.
More information about the webkit-reviews
mailing list