[webkit-reviews] review granted: [Bug 212382] SamplingProfiler::takeSample() should assume that ENABLE(WEBASSEMBLY) means Wasm is enabled. : [Attachment 400267] proposed patch.

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Tue May 26 12:23:25 PDT 2020


Saam Barati <sbarati at apple.com> has granted Mark Lam <mark.lam at apple.com>'s
request for review:
Bug 212382: SamplingProfiler::takeSample() should assume that
ENABLE(WEBASSEMBLY) means Wasm is enabled.
https://bugs.webkit.org/show_bug.cgi?id=212382

Attachment 400267: proposed patch.

https://bugs.webkit.org/attachment.cgi?id=400267&action=review




--- Comment #2 from Saam Barati <sbarati at apple.com> ---
Comment on attachment 400267
  --> https://bugs.webkit.org/attachment.cgi?id=400267
proposed patch.

View in context: https://bugs.webkit.org/attachment.cgi?id=400267&action=review

> Source/JavaScriptCore/ChangeLog:3
> +	   SamplingProfiler::takeSample() should assume that
ENABLE(WEBASSEMBLY) means Wasm is enabled.

should => should not


More information about the webkit-reviews mailing list