[webkit-reviews] review granted: [Bug 187839] Hardware fill-forwards animation and transitions don't interact correctly : [Attachment 400256] Patch

[bugzilla-daemon at webkit.org]

Simon Fraser (smfr) <simon.fraser at apple.com> has granted Antoine Quint
<graouts at apple.com>'s request for review:
Bug 187839: Hardware fill-forwards animation and transitions don't interact
correctly
https://bugs.webkit.org/show_bug.cgi?id=187839

Attachment 400256: Patch

https://bugs.webkit.org/attachment.cgi?id=400256&action=review




--- Comment #10 from Simon Fraser (smfr) <simon.fraser at apple.com> ---
Comment on attachment 400256
  --> https://bugs.webkit.org/attachment.cgi?id=400256
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=400256&action=review

> Source/WebCore/animation/AnimationTimeline.cpp:389
> +	   if (animation && animation->isRelevant()) {

isRelevant() is so vague. Relevant to whom?

> Source/WebCore/animation/ElementAnimationRareData.h:55
> +    void setLastStyleChangeEventStyle(std::unique_ptr<const RenderStyle>
style) { m_lastStyleChangeEventStyle = WTFMove(style); }

std::unique_ptr<const RenderStyle>&&

> Source/WebCore/dom/Element.h:506
> +    void setLastStyleChangeEventStyle(std::unique_ptr<const RenderStyle>);

std::unique_ptr<const RenderStyle>&&

>
LayoutTests/webanimations/updating-property-targeted-by-css-transition-during-c
ss-animation.html:4
> +<style type="text/css" media="screen">

Just <style>