[webkit-reviews] review denied: [Bug 212312] [PlayStation] Enable RemoteWebInspector : [Attachment 400151] Patch

[bugzilla-daemon at webkit.org]

Don Olmstead <don.olmstead at sony.com> has denied Yoshiaki Jitsukawa
<yoshiaki.jitsukawa at sony.com>'s request for review:
Bug 212312: [PlayStation] Enable RemoteWebInspector
https://bugs.webkit.org/show_bug.cgi?id=212312

Attachment 400151: Patch

https://bugs.webkit.org/attachment.cgi?id=400151&action=review




--- Comment #2 from Don Olmstead <don.olmstead at sony.com> ---
Comment on attachment 400151
  --> https://bugs.webkit.org/attachment.cgi?id=400151
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=400151&action=review

> Source/JavaScriptCore/API/JSRemoteInspectorServer.cpp:33
> +    auto& server = Inspector::RemoteInspectorServer::singleton();

Any reason this should change?

> Source/JavaScriptCore/PlatformPlayStation.cmake:2
> +    API/JSBasePrivate.h

I know why you have this here since there's that unhandled promise handler
rejection handler that never became a public C API but its still a
PRIVATE_FRAMEWORK_HEADER. Add it to the list of headers to install.

> Source/WTF/wtf/PlatformEnable.h:100
> +#include <wtf/PlatformEnablePlayStation.h>

I feel like this is a separate change unrelated to this bug.

> Source/cmake/OptionsPlayStation.cmake:35
> +WEBKIT_OPTION_DEFAULT_PORT_VALUE(ENABLE_REMOTE_INSPECTOR PRIVATE ON)

You need to remove ENABLE_REMOTE_INSPECTOR from the Experimental features
listing below.