[webkit-reviews] review granted: [Bug 212314] [GTK4] Make PointerLock work : [Attachment 400158] Patch

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Tue May 26 08:19:20 PDT 2020


Adrian Perez <aperez at igalia.com> has granted Carlos Garcia Campos
<cgarcia at igalia.com>'s request for review:
Bug 212314: [GTK4] Make PointerLock work
https://bugs.webkit.org/show_bug.cgi?id=212314

Attachment 400158: Patch

https://bugs.webkit.org/attachment.cgi?id=400158&action=review




--- Comment #2 from Adrian Perez <aperez at igalia.com> ---
Comment on attachment 400158
  --> https://bugs.webkit.org/attachment.cgi?id=400158
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=400158&action=review

> Source/WebKit/UIProcess/API/gtk/WebKitWebViewBase.cpp:166
> +#if USE(GTK4)

You don't need this #if, we have a “gdk_event_get_root_coords()”
stub in “GtkVersioning.h” which works for GTK4 :)


More information about the webkit-reviews mailing list