[webkit-reviews] review granted: [Bug 212054] [css-flexbox] WPT Test css/css-flexbox/flex-lines/multi-line-wrap-reverse-column-reverse.html fails : [Attachment 400220] Patch

[bugzilla-daemon at webkit.org]

Manuel Rego Casasnovas <rego at igalia.com> has granted Carlos Alberto Lopez Perez
<clopez at igalia.com>'s request for review:
Bug 212054: [css-flexbox] WPT Test
css/css-flexbox/flex-lines/multi-line-wrap-reverse-column-reverse.html fails
https://bugs.webkit.org/show_bug.cgi?id=212054

Attachment 400220: Patch

https://bugs.webkit.org/attachment.cgi?id=400220&action=review




--- Comment #3 from Manuel Rego Casasnovas <rego at igalia.com> ---
Comment on attachment 400220
  --> https://bugs.webkit.org/attachment.cgi?id=400220
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=400220&action=review

r=me, the change looks good just a minor comment about using red color.
Apart from that I'm not sure if I need to review the PR in WPT or it's enough
with the review here, please let me know. Thanks for the fix.

>
LayoutTests/imported/w3c/web-platform-tests/css/css-flexbox/flex-lines/multi-li
ne-wrap-reverse-column-reverse-expected.html:25
> +	   color: red;

Please avoid using "red" for things that are on the expected output (as red
usually means wrong behavior). Just change it for another color.