[webkit-reviews] review granted: [Bug 212359] Expose more network metrics to WebCoreNSURLSession : [Attachment 400212] Patch

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Mon May 25 14:29:58 PDT 2020

Darin Adler <darin at apple.com> has granted Alex Christensen
<achristensen at apple.com>'s request for review:
Bug 212359: Expose more network metrics to WebCoreNSURLSession

Attachment 400212: Patch


--- Comment #2 from Darin Adler <darin at apple.com> ---
Comment on attachment 400212
  --> https://bugs.webkit.org/attachment.cgi?id=400212

View in context: https://bugs.webkit.org/attachment.cgi?id=400212&action=review

> Source/WTF/wtf/PlatformHave.h:407
> +#if (PLATFORM(MAC) && __MAC_OS_X_VERSION_MIN_REQUIRED >= 101500) ||

The second half of this expression has the mistake Tim Horton mentioned
recently, where it checks IOS_FAMILY, but checks
__IPHONE_OS_VERSION_MIN_REQUIRED, which is frozen at an old value on watchOS
and tvOS. It should either just check PLATFORM(IOS) and accept this will be
false for tvOS and watchOS, or add minimum versions for those platforms.

More information about the webkit-reviews mailing list