[webkit-reviews] review granted: [Bug 212337] Extended Color Cleanup: Use the name SimpleColor consistently : [Attachment 400184] Patch

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Mon May 25 08:49:00 PDT 2020

Anders Carlsson <andersca at apple.com> has granted Sam Weinig <sam at webkit.org>'s
request for review:
Bug 212337: Extended Color Cleanup: Use the name SimpleColor consistently

Attachment 400184: Patch


--- Comment #6 from Anders Carlsson <andersca at apple.com> ---
Comment on attachment 400184
  --> https://bugs.webkit.org/attachment.cgi?id=400184

View in context: https://bugs.webkit.org/attachment.cgi?id=400184&action=review

> Source/WebCore/ChangeLog:12
> +	     the type it returns. Also took the opertunity to make it return


> Source/WebCore/ChangeLog:15
> +	     It made not real sense to keep it in Color.h

"It made not"

> Source/WebCore/css/parser/CSSParserFastPaths.cpp:423
> +	   auto color = SimpleColor::parseHexColor(characters, length);

Can write this as

if (auto color = ...)
    return color;

More information about the webkit-reviews mailing list