[webkit-reviews] review granted: [Bug 212337] Extended Color Cleanup: Use the name SimpleColor consistently : [Attachment 400184] Patch

[bugzilla-daemon at webkit.org]

Anders Carlsson <andersca at apple.com> has granted Sam Weinig <sam at webkit.org>'s
request for review:
Bug 212337: Extended Color Cleanup: Use the name SimpleColor consistently
https://bugs.webkit.org/show_bug.cgi?id=212337

Attachment 400184: Patch

https://bugs.webkit.org/attachment.cgi?id=400184&action=review




--- Comment #6 from Anders Carlsson <andersca at apple.com> ---
Comment on attachment 400184
  --> https://bugs.webkit.org/attachment.cgi?id=400184
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=400184&action=review

> Source/WebCore/ChangeLog:12
> +	     the type it returns. Also took the opertunity to make it return

"opertunity"

> Source/WebCore/ChangeLog:15
> +	     It made not real sense to keep it in Color.h

"It made not"

> Source/WebCore/css/parser/CSSParserFastPaths.cpp:423
> +	   auto color = SimpleColor::parseHexColor(characters, length);

Can write this as

if (auto color = ...)
    return color;