[webkit-reviews] review granted: [Bug 212344] [GTK4] Fix context menu : [Attachment 400196] Patch

[bugzilla-daemon at webkit.org]

Adrian Perez <aperez at igalia.com> has granted Carlos Garcia Campos
<cgarcia at igalia.com>'s request for review:
Bug 212344: [GTK4] Fix context menu
https://bugs.webkit.org/show_bug.cgi?id=212344

Attachment 400196: Patch

https://bugs.webkit.org/attachment.cgi?id=400196&action=review




--- Comment #3 from Adrian Perez <aperez at igalia.com> ---
Comment on attachment 400196
  --> https://bugs.webkit.org/attachment.cgi?id=400196
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=400196&action=review

> Source/WebKit/UIProcess/API/gtk/WebKitWebViewBase.cpp:859
> +	  
gtk_native_check_resize(GTK_NATIVE(priv->activeContextMenuProxy->gtkWidget()));

Cannot we do this inside “WebContextMenuProxyGtk”? We know that the
web view widget is valid when instantiating it, so I would expect that
calling “gtk_native_check_resize()” after setting the web view as parent
widget could work as well ��️