[webkit-reviews] review granted: [Bug 182695] Use child text content when determining whether to bail early in running a script : [Attachment 400052] Patch

[bugzilla-daemon at webkit.org]

youenn fablet <youennf at gmail.com> has granted Rob Buis <rbuis at igalia.com>'s
request for review:
Bug 182695: Use child text content when determining whether to bail early in
running a script
https://bugs.webkit.org/show_bug.cgi?id=182695

Attachment 400052: Patch

https://bugs.webkit.org/attachment.cgi?id=400052&action=review




--- Comment #2 from youenn fablet <youennf at gmail.com> ---
Comment on attachment 400052
  --> https://bugs.webkit.org/attachment.cgi?id=400052
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=400052&action=review

> Source/WebCore/dom/ScriptElement.cpp:184
> +    const String& sourceText = scriptContent();

s/const String&/auto, scriptContent() is returning a String.
If we need to optimise this a bit, maybe we should add a
TextNodeTraversal::isEmpty routine so that we create the string only when
executing the script.