[webkit-reviews] review granted: [Bug 212280] [CMake] Add static analyzers : [Attachment 400079] Patch

[bugzilla-daemon at webkit.org]

David Kilzer (:ddkilzer) <ddkilzer at webkit.org> has granted Don Olmstead
<don.olmstead at sony.com>'s request for review:
Bug 212280: [CMake] Add static analyzers
https://bugs.webkit.org/show_bug.cgi?id=212280

Attachment 400079: Patch

https://bugs.webkit.org/attachment.cgi?id=400079&action=review




--- Comment #3 from David Kilzer (:ddkilzer) <ddkilzer at webkit.org> ---
Comment on attachment 400079
  --> https://bugs.webkit.org/attachment.cgi?id=400079
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=400079&action=review

r=me

> ChangeLog:11
> +	   Add support for static analyzers within CMake builds. Supported
analyzers are
> +	   clang-tidy, iwyu (include-what-you-use) and lwyu
(link-what-you-use). They can
> +	   be enabled by passing a semicolon separated list to CMake through
the ANALYZERS
> +	   option.

Is the clang static analyzer supported in a different way?  (I'm curious
because that's the first "analyzer" I think of when I see the word.  No need to
change this patch to accomodate.)

> Source/cmake/WebKitFeatures.cmake:92
> +	   message(STATUS "Unified builds are disabled when analyzing sources")

I'm curious why this is.  When using the clang static analyzer, it's actually
more useful to build with unified sources because it gives the static analyzer
more code to work with (especially in deep mode).