[webkit-reviews] review granted: [Bug 212265] Extended Color Cleanup: Make alpha premultiplication code more consistent and clear regarding what works with extended colors : [Attachment 400055] Patch

[bugzilla-daemon at webkit.org]

Simon Fraser (smfr) <simon.fraser at apple.com> has granted Sam Weinig
<sam at webkit.org>'s request for review:
Bug 212265: Extended Color Cleanup: Make alpha premultiplication code more
consistent and clear regarding what works with extended colors
https://bugs.webkit.org/show_bug.cgi?id=212265

Attachment 400055: Patch

https://bugs.webkit.org/attachment.cgi?id=400055&action=review




--- Comment #2 from Simon Fraser (smfr) <simon.fraser at apple.com> ---
Comment on attachment 400055
  --> https://bugs.webkit.org/attachment.cgi?id=400055
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=400055&action=review

> Source/WebCore/platform/graphics/ColorUtilities.h:194
> +WEBCORE_EXPORT FloatComponents premultiplyAlpha(const FloatComponents&
sRGBCompontents);

Maybe just premultiplied()? "premultiply" sounds like it's in-place, and the
"alpha" is a given.