[webkit-reviews] review granted: [Bug 212160] [Apple Pay] Add new ApplePayInstallmentConfiguration members : [Attachment 400022] Patch

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Fri May 22 11:13:14 PDT 2020


Alex Christensen <achristensen at apple.com> has granted Andy Estes
<aestes at apple.com>'s request for review:
Bug 212160: [Apple Pay] Add new ApplePayInstallmentConfiguration members
https://bugs.webkit.org/show_bug.cgi?id=212160

Attachment 400022: Patch

https://bugs.webkit.org/attachment.cgi?id=400022&action=review




--- Comment #4 from Alex Christensen <achristensen at apple.com> ---
Comment on attachment 400022
  --> https://bugs.webkit.org/attachment.cgi?id=400022
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=400022&action=review

> Source/WebCore/Modules/applepay/PaymentInstallmentConfiguration.mm:217
> +	   applicationMetadataDictionary =
dynamic_objc_cast<NSDictionary>([NSJSONSerialization
JSONObjectWithData:applicationMetadata options:0 error:nil]);

Maybe we should pass an NSError** and return an exception here?


More information about the webkit-reviews mailing list