[webkit-reviews] review granted: [Bug 212264] [css-flex] Allow indefinite size flex items to be definite wrt resolving percentages inside them : [Attachment 400050] Patch

[bugzilla-daemon at webkit.org]

Manuel Rego Casasnovas <rego at igalia.com> has granted Sergio Villar Senin
<svillar at igalia.com>'s request for review:
Bug 212264: [css-flex] Allow indefinite size flex items to be definite wrt
resolving percentages inside them
https://bugs.webkit.org/show_bug.cgi?id=212264

Attachment 400050: Patch

https://bugs.webkit.org/attachment.cgi?id=400050&action=review




--- Comment #3 from Manuel Rego Casasnovas <rego at igalia.com> ---
Comment on attachment 400050
  --> https://bugs.webkit.org/attachment.cgi?id=400050
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=400050&action=review

r=me, thanks for the patch.

> LayoutTests/css3/flexbox/definite-main-size.html:61
>    <div class="rect flex-none"></div>

Would be nice to move this test "definite-main-size.html" into WPT. It seems it
doesn't have anything engine related.

Of course this could be done in a follow-up patch.