[webkit-reviews] review granted: [Bug 212245] DataTransfer.files contains multiple files when pasting a single image with multiple representations : [Attachment 400010] Patch

[bugzilla-daemon at webkit.org]

Tim Horton <thorton at apple.com> has granted Wenson Hsieh
<wenson_hsieh at apple.com>'s request for review:
Bug 212245: DataTransfer.files contains multiple files when pasting a single
image with multiple representations
https://bugs.webkit.org/show_bug.cgi?id=212245

Attachment 400010: Patch

https://bugs.webkit.org/attachment.cgi?id=400010&action=review




--- Comment #2 from Tim Horton <thorton at apple.com> ---
Comment on attachment 400010
  --> https://bugs.webkit.org/attachment.cgi?id=400010
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=400010&action=review

> Tools/DumpRenderTree/mac/DumpRenderTreePasteboard.mm:246
> -    _writtenPasteboardItems = adoptNS([[NSMutableArray<NSPasteboardItem *>
alloc] initWithCapacity:objects.count]);
> +    auto items = adoptNS([[NSMutableArray<NSPasteboardItem *> alloc]
initWithCapacity:objects.count]);

It looks funny to see the type specialization there! But I guess it is fine.

> Tools/TestWebKitAPI/Tests/WebKitCocoa/PasteImage.mm:58
> +    for (NSDictionary <NSString *, NSData *> *typesAndData in items) {

No space before the < ... I /think/?