[webkit-reviews] review granted: [Bug 212156] [Mac, WK2] Fullscreen animation missing a few frames at beginning : [Attachment 399863] Patch

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Thu May 21 14:42:42 PDT 2020

Eric Carlson <eric.carlson at apple.com> has granted Jer Noble
<jer.noble at apple.com>'s request for review:
Bug 212156: [Mac,WK2] Fullscreen animation missing a few frames at beginning

Attachment 399863: Patch


--- Comment #3 from Eric Carlson <eric.carlson at apple.com> ---
Comment on attachment 399863
  --> https://bugs.webkit.org/attachment.cgi?id=399863

View in context: https://bugs.webkit.org/attachment.cgi?id=399863&action=review

> Source/WebKit/ChangeLog:9
> +	   When starting the animation, ensure that the fullscreen window is
ordered front, and on top

s/the animation/the enter fullscreen animation/

> Source/WebKit/UIProcess/mac/WKFullScreenWindowController.mm:325
> +    [clipLayer addAnimation:zoomAnimation(_initialFrame, _finalFrame,
self.window.screen.frame, 1e10, AnimateIn) forKey:@"fullscreen"];
> +    clipLayer.mask = createMask(contentView.bounds);
> +    [clipLayer.mask addAnimation:maskAnimation(_initialFrame, _finalFrame,
self.window.screen.frame, 1e10, AnimateIn) forKey:@"fullscreen"];

`1e10` probably deserves a named constant to make it clear why we use it.

More information about the webkit-reviews mailing list