[webkit-reviews] review granted: [Bug 212220] [css-grid] Grid items shouldn't be created for white spaces. : [Attachment 399967] Patch

[bugzilla-daemon at webkit.org]

Manuel Rego Casasnovas <rego at igalia.com> has granted Oriol Brufau
<obrufau at igalia.com>'s request for review:
Bug 212220: [css-grid] Grid items shouldn't be created for white spaces.
https://bugs.webkit.org/show_bug.cgi?id=212220

Attachment 399967: Patch

https://bugs.webkit.org/attachment.cgi?id=399967&action=review




--- Comment #2 from Manuel Rego Casasnovas <rego at igalia.com> ---
Comment on attachment 399967
  --> https://bugs.webkit.org/attachment.cgi?id=399967
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=399967&action=review

r=me, but please wait for green EWSs before landing.

> Source/WebCore/rendering/updating/RenderTreeUpdater.cpp:432
>      if (parentRenderer.isFlexibleBox() && !parentRenderer.isRenderButton())

Mmm, ok I see the condition for flexbox in this line, usually we have both
conditions together.
Not a big deal but maybe we can just join both ifs.