[webkit-reviews] review granted: [Bug 212180] [macOS] TestWebKitAPI.WebKit.HTTPReferer is a flaky failure : [Attachment 399966] Patch

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Thu May 21 10:42:09 PDT 2020


Chris Dumez <cdumez at apple.com> has granted Alex Christensen
<achristensen at apple.com>'s request for review:
Bug 212180: [macOS] TestWebKitAPI.WebKit.HTTPReferer is a flaky failure
https://bugs.webkit.org/show_bug.cgi?id=212180

Attachment 399966: Patch

https://bugs.webkit.org/attachment.cgi?id=399966&action=review




--- Comment #5 from Chris Dumez <cdumez at apple.com> ---
Comment on attachment 399966
  --> https://bugs.webkit.org/attachment.cgi?id=399966
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=399966&action=review

> Tools/TestWebKitAPI/cocoa/HTTPServer.h:53
> +    NSURLRequest *request(const String& path = "/") const;

"/"_str

> Tools/TestWebKitAPI/cocoa/HTTPServer.mm:184
> +	   responseBuilder.append("HTTP/1.1 ");

These things could use appendLiteral()


More information about the webkit-reviews mailing list