[webkit-reviews] review granted: [Bug 209822] Cannot style ::selection for a flex container : [Attachment 399934] Patch

[bugzilla-daemon at webkit.org]

Antti Koivisto <koivisto at iki.fi> has granted Tyler Wilcock
<twilco.o at protonmail.com>'s request for review:
Bug 209822: Cannot style ::selection for a flex container
https://bugs.webkit.org/show_bug.cgi?id=209822

Attachment 399934: Patch

https://bugs.webkit.org/attachment.cgi?id=399934&action=review




--- Comment #10 from Antti Koivisto <koivisto at iki.fi> ---
Comment on attachment 399934
  --> https://bugs.webkit.org/attachment.cgi?id=399934
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=399934&action=review

> Source/WebCore/rendering/RenderObject.cpp:170
> +    RenderElement* ancestor = parent();

Could use auto*

> Source/WebCore/rendering/RenderText.h:287
> +    if (RenderElement* ancestor = firstNonAnonymousAncestor())

Here too

> Source/WebCore/rendering/RenderText.h:294
> +    if (RenderElement* ancestor = firstNonAnonymousAncestor())

etc