[webkit-reviews] review granted: [Bug 191365] [css-grid] width of table in a grid is incorrect when table cell has width:100% : [Attachment 399953] Patch

[bugzilla-daemon at webkit.org]

Manuel Rego Casasnovas <rego at igalia.com> has granted Sergio Villar Senin
<svillar at igalia.com>'s request for review:
Bug 191365: [css-grid] width of table in a grid is incorrect when table cell
has width:100%
https://bugs.webkit.org/show_bug.cgi?id=191365

Attachment 399953: Patch

https://bugs.webkit.org/attachment.cgi?id=399953&action=review




--- Comment #4 from Manuel Rego Casasnovas <rego at igalia.com> ---
Comment on attachment 399953
  --> https://bugs.webkit.org/attachment.cgi?id=399953
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=399953&action=review

r+

> Source/WebCore/ChangeLog:3
> +	   [css-grid] width of table in a grid is incorrect when table cell has
width:100%

This is also for flexbox, so please reword the title adding [css-flex] and
mentioning flexbox too.

> Source/WebCore/rendering/AutoTableLayout.cpp:201
> +	   // The max logical width of a table may be "infinity" (or
tableMaxWidth, to
> +	   // be more exact) if the sum of the columns' percentages is 100% or
more,
> +	   // AND there is at least one column that has a non-percentage-based
positive
> +	   // logical width. In such situations no table logical width will be
large
> +	   // enough to satisfy the constraint set by the contents. So the idea
is to
> +	   // use ~infinity to make sure we use all available size in the
containing
> +	   // block. However, this just doesn't work if this is a flex or grid
item, so
> +	   // disallow scaling in that case.

Nit: You don't need to wrap comments to 80 chars in WebKit.