[webkit-reviews] review granted: [Bug 212167] Array.prototype.concat is incorrect with objects whose "length" exceeds 2 ** 32 - 1 : [Attachment 399892] Patch
bugzilla-daemon at webkit.org
bugzilla-daemon at webkit.org
Wed May 20 15:24:44 PDT 2020
Saam Barati <sbarati at apple.com> has granted Alexey Shvayka
<shvaikalesh at gmail.com>'s request for review:
Bug 212167: Array.prototype.concat is incorrect with objects whose "length"
exceeds 2 ** 32 - 1
https://bugs.webkit.org/show_bug.cgi?id=212167
Attachment 399892: Patch
https://bugs.webkit.org/attachment.cgi?id=399892&action=review
--- Comment #2 from Saam Barati <sbarati at apple.com> ---
Comment on attachment 399892
--> https://bugs.webkit.org/attachment.cgi?id=399892
Patch
View in context: https://bugs.webkit.org/attachment.cgi?id=399892&action=review
> Source/JavaScriptCore/builtins/ArrayConstructor.js:72
> + if (k >= @MAX_SAFE_INTEGER)
should be >, no?
More information about the webkit-reviews
mailing list