[webkit-reviews] review granted: [Bug 212034] Support operating dates in ResourceLoadStatisticsDatabaseStore : [Attachment 399870] Patch

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Wed May 20 14:53:37 PDT 2020

Brent Fulgham <bfulgham at webkit.org> has granted katherine_cheney at apple.com's
request for review:
Bug 212034: Support operating dates in ResourceLoadStatisticsDatabaseStore

Attachment 399870: Patch


--- Comment #10 from Brent Fulgham <bfulgham at webkit.org> ---
Comment on attachment 399870
  --> https://bugs.webkit.org/attachment.cgi?id=399870

View in context: https://bugs.webkit.org/attachment.cgi?id=399870&action=review

This looks great! r=me.

> +    Optional<Seconds> expirationDateTime = statisticsExpirationTime();

Oh gosh. What a typo! Thanks! :-)

> +	   double daysToSubtract = Seconds::fromHours(24 * i).value();

If we have to do this frequently, we should consider making a
'Seconds::fromDays()' helper. But not right now.

More information about the webkit-reviews mailing list