[webkit-reviews] review granted: [Bug 212034] Support operating dates in ResourceLoadStatisticsDatabaseStore : [Attachment 399870] Patch

[bugzilla-daemon at webkit.org]

Brent Fulgham <bfulgham at webkit.org> has granted katherine_cheney at apple.com's
request for review:
Bug 212034: Support operating dates in ResourceLoadStatisticsDatabaseStore
https://bugs.webkit.org/show_bug.cgi?id=212034

Attachment 399870: Patch

https://bugs.webkit.org/attachment.cgi?id=399870&action=review




--- Comment #10 from Brent Fulgham <bfulgham at webkit.org> ---
Comment on attachment 399870
  --> https://bugs.webkit.org/attachment.cgi?id=399870
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=399870&action=review

This looks great! r=me.

>
Source/WebKit/NetworkProcess/Classifier/ResourceLoadStatisticsDatabaseStore.cpp
:2428
> +    Optional<Seconds> expirationDateTime = statisticsExpirationTime();

Oh gosh. What a typo! Thanks! :-)

>
Source/WebKit/NetworkProcess/Classifier/ResourceLoadStatisticsDatabaseStore.cpp
:3059
> +	   double daysToSubtract = Seconds::fromHours(24 * i).value();

If we have to do this frequently, we should consider making a
'Seconds::fromDays()' helper. But not right now.