[webkit-reviews] review granted: [Bug 212103] [Web Animations] Animation engine should not wake up every tick for steps timing functions : [Attachment 399835] Patch

[bugzilla-daemon at webkit.org]

Simon Fraser (smfr) <simon.fraser at apple.com> has granted Antoine Quint
<graouts at apple.com>'s request for review:
Bug 212103: [Web Animations] Animation engine should not wake up every tick for
steps timing functions
https://bugs.webkit.org/show_bug.cgi?id=212103

Attachment 399835: Patch

https://bugs.webkit.org/attachment.cgi?id=399835&action=review




--- Comment #8 from Simon Fraser (smfr) <simon.fraser at apple.com> ---
Comment on attachment 399835
  --> https://bugs.webkit.org/attachment.cgi?id=399835
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=399835&action=review

> Source/WebCore/animation/KeyframeEffect.cpp:1476
> +    if (index < 0)
> +	   return nullptr;

size_t is unsigned, this can never happen.

> Source/WebCore/animation/KeyframeEffect.cpp:1837
> +Optional<double> KeyframeEffect::progressUntilNextStep(double
iterationProgress) const

"progress until" is a bit ambiguous here. Maybe "progress at next step"?