[webkit-reviews] review granted: [Bug 212086] [FlatPak SDK] Missing ruby gems json and highline : [Attachment 399836] Patch

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Wed May 20 07:38:11 PDT 2020

Adrian Perez <aperez at igalia.com> has granted  review:
Bug 212086: [FlatPak SDK] Missing ruby gems json and highline

Attachment 399836: Patch


--- Comment #9 from Adrian Perez <aperez at igalia.com> ---
Comment on attachment 399836
  --> https://bugs.webkit.org/attachment.cgi?id=399836

View in context: https://bugs.webkit.org/attachment.cgi?id=399836&action=review

All looking nice and tidy now! =)

> Tools/buildstream/elements/sdk/ruby-highline.bst:19
> +	 gem install --local --ignore-dependencies --no-user-install
--no-document --install-dir "$(ruby -e'puts Gem.default_dir')" --bindir
%{install-root}%{prefix}/bin --build-root '%{install-root}' *.gem

Oh, using %{prefix} here is even an improvement over what I suggested. Neat.

More information about the webkit-reviews mailing list