[webkit-reviews] review requested: [Bug 212086] [FlatPak SDK] Missing ruby gems json and highline : [Attachment 399830] Patch

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Wed May 20 06:19:28 PDT 2020

Adrian Perez <aperez at igalia.com> has asked  for review:
Bug 212086: [FlatPak SDK] Missing ruby gems json and highline

Attachment 399830: Patch


--- Comment #4 from Adrian Perez <aperez at igalia.com> ---
Comment on attachment 399830
  --> https://bugs.webkit.org/attachment.cgi?id=399830

View in context: https://bugs.webkit.org/attachment.cgi?id=399830&action=review

> Tools/buildstream/elements/sdk/ruby-highline.bst:22
> +	 mv /tmp/gem-tmp/gems/*/lib/*

Why not asking Ruby itself where it wants libraries installed? Also, the
“gem install“ command could be instructed to copy files directly inside
the target installation directory instead of manually moving files around.
This command should be enough:

  gem install --local --ignore-dependencies --no-user-install --no-document \
      --install-dir "$(ruby -e'puts Gem.default_dir')" \
      --bindir /usr/bin --build-root '%{install-root}' \

(This is basically what GNU/Linux distributions do for Ruby packages.)

More information about the webkit-reviews mailing list