[webkit-reviews] review denied: [Bug 212126] [GTK4] Build error with gtk4 on PluginProcessMainUnix.cpp : [Attachment 399810] Patch

[bugzilla-daemon at webkit.org]

Adrian Perez <aperez at igalia.com> has denied Santosh Mahto
<santosh.mahto at collabora.com>'s request for review:
Bug 212126: [GTK4] Build error with gtk4 on PluginProcessMainUnix.cpp
https://bugs.webkit.org/show_bug.cgi?id=212126

Attachment 399810: Patch

https://bugs.webkit.org/attachment.cgi?id=399810&action=review




--- Comment #5 from Adrian Perez <aperez at igalia.com> ---
Comment on attachment 399810
  --> https://bugs.webkit.org/attachment.cgi?id=399810
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=399810&action=review

> Source/WebKit/ChangeLog:8
> +	   * PluginProcess/unix/PluginProcessMainUnix.cpp:

NPAPI plug-in support is disabled for GTK4 builds. We are not planning
to support them, given that all major browsers are phasing out the support
(or have already).

> Source/WebKit/PluginProcess/unix/PluginProcessMainUnix.cpp:64
>	   gtk_init(nullptr, nullptr);

…anyway, instead of doing this, you should leave the call to gtk_init()
unchanged and instead the <WebCore/GtkVersioning.h>, which has utility
functions that avoid the need for preprocessor guards.