[webkit-reviews] review granted: [Bug 212060] Hide password echo when screen is being captured. : [Attachment 399801] Patch

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Tue May 19 21:37:17 PDT 2020


Wenson Hsieh <wenson_hsieh at apple.com> has granted Megan Gardner
<megan_gardner at apple.com>'s request for review:
Bug 212060: Hide password echo when screen is being captured.
https://bugs.webkit.org/show_bug.cgi?id=212060

Attachment 399801: Patch

https://bugs.webkit.org/attachment.cgi?id=399801&action=review




--- Comment #8 from Wenson Hsieh <wenson_hsieh at apple.com> ---
Comment on attachment 399801
  --> https://bugs.webkit.org/attachment.cgi?id=399801
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=399801&action=review

> Source/WebKit/UIProcess/ios/WKContentView.mm:776
> +- (void)_screenCapturedDidChange:(NSNotification*)notification

Nit - space before the *.

> Source/WebKit/WebProcess/WebPage/WebPage.h:2002
> +    WebCore::FloatSize m_screenCaptured;

I think you meant to delete this.


More information about the webkit-reviews mailing list