[webkit-reviews] review granted: [Bug 212105] [Wasm] Limit the size of Wasm function we optimize in OMG mode : [Attachment 399798] Patch

[bugzilla-daemon at webkit.org]

Filip Pizlo <fpizlo at apple.com> has granted Michael Saboff <msaboff at apple.com>'s
request for review:
Bug 212105: [Wasm] Limit the size of Wasm function we optimize in OMG mode
https://bugs.webkit.org/show_bug.cgi?id=212105

Attachment 399798: Patch

https://bugs.webkit.org/attachment.cgi?id=399798&action=review




--- Comment #5 from Filip Pizlo <fpizlo at apple.com> ---
Comment on attachment 399798
  --> https://bugs.webkit.org/attachment.cgi?id=399798
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=399798&action=review

> Source/JavaScriptCore/wasm/WasmB3IRGenerator.cpp:540
> +    if (m_info.functions[m_functionIndex].data.size() <
Options::webAssemblyBBQFallbackSize())

Can we abstract this inequality, so it’s if (functionCall) here and the other
places you do this less than check?