[webkit-reviews] review granted: [Bug 212090] SQLite database fails to close in SQLiteIDBBackingStore::databaseNameFromFile : [Attachment 399747] Patch

[bugzilla-daemon at webkit.org]

Darin Adler <darin at apple.com> has granted Sihui Liu <sihui_liu at apple.com>'s
request for review:
Bug 212090: SQLite database fails to close in
SQLiteIDBBackingStore::databaseNameFromFile
https://bugs.webkit.org/show_bug.cgi?id=212090

Attachment 399747: Patch

https://bugs.webkit.org/attachment.cgi?id=399747&action=review




--- Comment #2 from Darin Adler <darin at apple.com> ---
Comment on attachment 399747
  --> https://bugs.webkit.org/attachment.cgi?id=399747
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=399747&action=review

> Source/WebCore/Modules/indexeddb/server/SQLiteIDBBackingStore.cpp:924
>	   database.close();

I suggest removing this line of code also.

> Source/WebCore/Modules/indexeddb/server/SQLiteIDBBackingStore.cpp:-929
> -    database.close();

I don’t think you need to do the rest of this change. Just removing this line
of code alone should fix the bug, without the restructuring.