[webkit-reviews] review granted: [Bug 211929] ITP database should finalize all prepared statements before closing : [Attachment 399762] Patch

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Tue May 19 14:58:36 PDT 2020

John Wilander <wilander at apple.com> has granted katherine_cheney at apple.com's
request for review:
Bug 211929: ITP database should finalize all prepared statements before closing

Attachment 399762: Patch


--- Comment #14 from John Wilander <wilander at apple.com> ---
Comment on attachment 399762
  --> https://bugs.webkit.org/attachment.cgi?id=399762

View in context: https://bugs.webkit.org/attachment.cgi?id=399762&action=review

Given that Sihui has looked this over, I'm OK with it too. See comments though.

> +SQLiteStatementAutoResetScope
::SQLiteStatement>& statement, const String query, const String& logString)

Our style guide says no get prefix. If you get a name conflict with a local
variable, you can call it with this->scopedStatement(). Can the query
parameters be ref?

> +	       RELEASE_LOG_ERROR(Network, "%p -
ResourceLoadStatisticsDatabaseStore::%s failed to prepare statement, error
message: %{private}s", this, logString.ascii().data(),

I don't remember the reason for keeping these error messages private. Can they
leak something about the user's browsing?

More information about the webkit-reviews mailing list