[webkit-reviews] review granted: [Bug 212093] REGRESSION (r259930): Dictation marker at start of text is removed when added trailing whitespace is collapsed : [Attachment 399771] Patch

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Tue May 19 14:29:39 PDT 2020


Daniel Bates <dbates at webkit.org> has granted Daniel Bates <dbates at webkit.org>'s
request for review:
Bug 212093: REGRESSION (r259930): Dictation marker at start of text is removed
when added trailing whitespace is collapsed
https://bugs.webkit.org/show_bug.cgi?id=212093

Attachment 399771: Patch

https://bugs.webkit.org/attachment.cgi?id=399771&action=review




--- Comment #11 from Daniel Bates <dbates at webkit.org> ---
Comment on attachment 399771
  --> https://bugs.webkit.org/attachment.cgi?id=399771
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=399771&action=review

Patch looks good. Needs change log for Tools change I did for you.

> Source/WebCore/dom/DocumentMarkerController.cpp:598
> +	   unsigned targetStartOffset =
clampTo<unsigned>(static_cast<int>(marker.startOffset()) + delta);

OK as-is. No change needed. Optimal solution would use auto because types in
template args <-- is that the right word?

> Source/WebCore/dom/DocumentMarkerController.cpp:599
> +	   unsigned targetEndOffset =
clampTo<unsigned>(static_cast<int>(marker.endOffset()) + delta);

Ditto.


More information about the webkit-reviews mailing list