[webkit-reviews] review granted: [Bug 212104] Checkpoint inlined call return handler needs an exception check when dispatching : [Attachment 399765] Patch

[bugzilla-daemon at webkit.org]

Yusuke Suzuki <ysuzuki at apple.com> has granted Keith Miller
<keith_miller at apple.com>'s request for review:
Bug 212104: Checkpoint inlined call return handler needs an exception check
when dispatching
https://bugs.webkit.org/show_bug.cgi?id=212104

Attachment 399765: Patch

https://bugs.webkit.org/attachment.cgi?id=399765&action=review




--- Comment #5 from Yusuke Suzuki <ysuzuki at apple.com> ---
Comment on attachment 399765
  --> https://bugs.webkit.org/attachment.cgi?id=399765
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=399765&action=review

>>> Source/JavaScriptCore/llint/LLIntSlowPaths.cpp:2093
>>> +
>> 
>> Can we insert exception check just after the operation which throws an
exception? Maybe, handleIteratorNextCheckpoint?
> 
> No, because the LLInt code we're returning to dispatches to whatever pc we
return. It's easier to handle it all here. This also means that other new
bytecodes "just work".

OK, make sense.