[webkit-reviews] review granted: [Bug 212075] [macOS] Drag and drop within a contenteditable area duplicates attachment-backed images : [Attachment 399742] Patch

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Tue May 19 10:00:15 PDT 2020


Andy Estes <aestes at apple.com> has granted Wenson Hsieh
<wenson_hsieh at apple.com>'s request for review:
Bug 212075: [macOS] Drag and drop within a contenteditable area duplicates
attachment-backed images
https://bugs.webkit.org/show_bug.cgi?id=212075

Attachment 399742: Patch

https://bugs.webkit.org/attachment.cgi?id=399742&action=review




--- Comment #2 from Andy Estes <aestes at apple.com> ---
Comment on attachment 399742
  --> https://bugs.webkit.org/attachment.cgi?id=399742
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=399742&action=review

> Source/WebKit/UIProcess/WebPageProxy.cpp:2458
> +	   m_mouseEventQueue.takeLast();

Maybe you want removeLast instead since you aren’t actually taking?


More information about the webkit-reviews mailing list