[webkit-reviews] review granted: [Bug 212071] [Mac] Use preferedPixelBufferFormat for AVVideoCaptureSource : [Attachment 399732] Patch

[bugzilla-daemon at webkit.org]

Eric Carlson <eric.carlson at apple.com> has granted  review:
Bug 212071: [Mac] Use preferedPixelBufferFormat for AVVideoCaptureSource
https://bugs.webkit.org/show_bug.cgi?id=212071

Attachment 399732: Patch

https://bugs.webkit.org/attachment.cgi?id=399732&action=review




--- Comment #2 from Eric Carlson <eric.carlson at apple.com> ---
Comment on attachment 399732
  --> https://bugs.webkit.org/attachment.cgi?id=399732
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=399732&action=review

> Source/WebCore/platform/mediastream/mac/AVVideoCaptureSource.mm:-83
> -    // FIXME: Use preferedPixelBufferFormat() once rdar://problem/44391444
is fixed.
> -#if PLATFORM(MAC)
> -    return kCVPixelFormatType_420YpCbCr8Planar;
> -#else
>      return preferedPixelBufferFormat();
> -#endif

We should make this conditional on the build target since the fix is unlikely
to be back ported. Maybe define something like
HAVE_DISPLAY_LAYER_PLANAR_SUPPORT?