[webkit-reviews] review granted: [Bug 212051] Replace TextIndicatorOptions with OptionSet<TextIndicatorOption> : [Attachment 399694] Patch v2

[bugzilla-daemon at webkit.org]

Simon Fraser (smfr) <simon.fraser at apple.com> has granted David Kilzer
(:ddkilzer) <ddkilzer at webkit.org>'s request for review:
Bug 212051: Replace TextIndicatorOptions with OptionSet<TextIndicatorOption>
https://bugs.webkit.org/show_bug.cgi?id=212051

Attachment 399694: Patch v2

https://bugs.webkit.org/attachment.cgi?id=399694&action=review




--- Comment #6 from Simon Fraser (smfr) <simon.fraser at apple.com> ---
Comment on attachment 399694
  --> https://bugs.webkit.org/attachment.cgi?id=399694
Patch v2

View in context: https://bugs.webkit.org/attachment.cgi?id=399694&action=review

> Source/WebCore/platform/ios/DragImageIOS.mm:148
> +    constexpr OptionSet<TextIndicatorOption> defaultLinkIndicatorOptions {
TextIndicatorOption::TightlyFitContent, TextIndicatorOption::RespectTextColor,
TextIndicatorOption::UseBoundingRectAndPaintAllContentForComplexRanges,
TextIndicatorOption::ExpandClipBeyondVisibleRect,
TextIndicatorOption::ComputeEstimatedBackgroundColor };

Maybe put these one per line.

> Source/WebCore/platform/ios/DragImageIOS.mm:168
> +constexpr OptionSet<TextIndicatorOption>
defaultSelectionDragImageTextIndicatorOptions {
TextIndicatorOption::ExpandClipBeyondVisibleRect,
TextIndicatorOption::PaintAllContent,
TextIndicatorOption::UseSelectionRectForSizing,
TextIndicatorOption::ComputeEstimatedBackgroundColor };

Ditto

> Source/WebCore/testing/Internals.h:966
> +	   OptionSet<WebCore::TextIndicatorOption> core()

core() is a really weird name.

> Source/WebKit/WebProcess/WebPage/ios/WebPageIOS.mm:1010
> +    constexpr OptionSet<TextIndicatorOption>
defaultTextIndicatorOptionsForEditDrag {
TextIndicatorOption::IncludeSnapshotOfAllVisibleContentWithoutSelection,
TextIndicatorOption::ExpandClipBeyondVisibleRect,
TextIndicatorOption::PaintAllContent,
TextIndicatorOption::IncludeMarginIfRangeMatchesSelection,
TextIndicatorOption::PaintBackgrounds,
TextIndicatorOption::ComputeEstimatedBackgroundColor,
TextIndicatorOption::UseSelectionRectForSizing,
TextIndicatorOption::IncludeSnapshotWithSelectionHighlight };

One per line

> Source/WebKit/WebProcess/WebPage/ios/WebPageIOS.mm:2607
> +	   { TextIndicatorOption::TightlyFitContent,
TextIndicatorOption::RespectTextColor, TextIndicatorOption::PaintBackgrounds,
TextIndicatorOption::UseBoundingRectAndPaintAllContentForComplexRanges,
TextIndicatorOption::IncludeMarginIfRangeMatchesSelection,
TextIndicatorOption::ComputeEstimatedBackgroundColor },

One per line

> Source/WebKitLegacy/mac/DOM/DOM.mm:526
> +    constexpr OptionSet<TextIndicatorOption> options {
TextIndicatorOption::TightlyFitContent, TextIndicatorOption::RespectTextColor,
TextIndicatorOption::PaintBackgrounds,
TextIndicatorOption::UseBoundingRectAndPaintAllContentForComplexRanges,
TextIndicatorOption::IncludeMarginIfRangeMatchesSelection };

One per line

> Source/WebKitLegacy/mac/WebView/WebView.mm:1964
> +    constexpr OptionSet<WebCore::TextIndicatorOption>
defaultEditDragTextIndicatorOptions {
WebCore::TextIndicatorOption::IncludeSnapshotOfAllVisibleContentWithoutSelectio
n, WebCore::TextIndicatorOption::ExpandClipBeyondVisibleRect,
WebCore::TextIndicatorOption::PaintAllContent,
WebCore::TextIndicatorOption::IncludeMarginIfRangeMatchesSelection,
WebCore::TextIndicatorOption::PaintBackgrounds,
WebCore::TextIndicatorOption::UseSelectionRectForSizing,
WebCore::TextIndicatorOption::IncludeSnapshotWithSelectionHighlight,
WebCore::TextIndicatorOption::RespectTextColor };

One per line