[webkit-reviews] review granted: [Bug 212031] webkitpy: Add Source/WebKit/Scripts/webkit as relevant path to webkitpy-ews : [Attachment 399655] Patch

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Mon May 18 18:05:28 PDT 2020


Alexey Proskuryakov <ap at webkit.org> has granted Lauro Moura
<lmoura at igalia.com>'s request for review:
Bug 212031: webkitpy: Add Source/WebKit/Scripts/webkit as relevant path to
webkitpy-ews
https://bugs.webkit.org/show_bug.cgi?id=212031

Attachment 399655: Patch

https://bugs.webkit.org/attachment.cgi?id=399655&action=review




--- Comment #2 from Alexey Proskuryakov <ap at webkit.org> ---
Comment on attachment 399655
  --> https://bugs.webkit.org/attachment.cgi?id=399655
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=399655&action=review

> Tools/Scripts/webkitpy/tool/steps/checkpatchrelevance.py:69
> +	   "Source/WebKit/Scripts/webkit/",

Seeing that test-webkitpy exercises this code, sure. Not sure great that
test-webkitpy tests code that is not webkitpy.


More information about the webkit-reviews mailing list