[webkit-reviews] review granted: [Bug 212050] Rare crash under -[WKContentView resignFirstResponderForWebView] : [Attachment 399677] Patch
bugzilla-daemon at webkit.org
bugzilla-daemon at webkit.org
Mon May 18 15:32:54 PDT 2020
Wenson Hsieh <wenson_hsieh at apple.com> has granted Tim Horton
<thorton at apple.com>'s request for review:
Bug 212050: Rare crash under -[WKContentView resignFirstResponderForWebView]
https://bugs.webkit.org/show_bug.cgi?id=212050
Attachment 399677: Patch
https://bugs.webkit.org/attachment.cgi?id=399677&action=review
--- Comment #3 from Wenson Hsieh <wenson_hsieh at apple.com> ---
Comment on attachment 399677
--> https://bugs.webkit.org/attachment.cgi?id=399677
Patch
View in context: https://bugs.webkit.org/attachment.cgi?id=399677&action=review
> Source/WebKit/UIProcess/ios/WKContentViewInteraction.mm:1412
> + if (strongSelf->_keyWebEventHandler.get() !=
strongHandler.get())
Nit - are both of these .get() needed?
More information about the webkit-reviews
mailing list