[webkit-reviews] review granted: [Bug 212028] WebPageProxy::DidCommitLoadForFrame should use FrameLoadType instead of casting to/from uint32_t for IPC : [Attachment 399653] Patch

[bugzilla-daemon at webkit.org]

David Kilzer (:ddkilzer) <ddkilzer at webkit.org> has granted Alex Christensen
<achristensen at apple.com>'s request for review:
Bug 212028: WebPageProxy::DidCommitLoadForFrame should use FrameLoadType
instead of casting to/from uint32_t for IPC
https://bugs.webkit.org/show_bug.cgi?id=212028

Attachment 399653: Patch

https://bugs.webkit.org/attachment.cgi?id=399653&action=review




--- Comment #4 from David Kilzer (:ddkilzer) <ddkilzer at webkit.org> ---
Comment on attachment 399653
  --> https://bugs.webkit.org/attachment.cgi?id=399653
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=399653&action=review

r=me

> Source/WebKit/UIProcess/WebPageProxy.messages.in:128
> +    DidCommitLoadForFrame(WebCore::FrameIdentifier frameID, struct
WebKit::FrameInfoData frameInfo, WebCore::ResourceRequest request, uint64_t
navigationID, String mimeType, bool hasCustomContentProvider, enum:uint8_t
WebCore::FrameLoadType loadType, WebCore::CertificateInfo certificateInfo, bool
usedLegacyTLS, bool containsPluginDocument,
Optional<WebCore::HasInsecureContent> forcedHasInsecureContent, enum:uint8_t
WebCore::MouseEventPolicy mouseEventPolicy, WebKit::UserData userData)

I haven't seen `enum:uint8_t` used before.  Is this change so you don't have to
tell messages.py about the header include for the type?  What happens if the
size changes in the header where it's defined?