[webkit-reviews] review granted: [Bug 211882] [WebGPU] Validation for GPUDevice.createTexture() : [Attachment 399633] Patch

[bugzilla-daemon at webkit.org]

Dean Jackson <dino at apple.com> has granted Myles C. Maxfield
<mmaxfield at apple.com>'s request for review:
Bug 211882: [WebGPU] Validation for GPUDevice.createTexture()
https://bugs.webkit.org/show_bug.cgi?id=211882

Attachment 399633: Patch

https://bugs.webkit.org/attachment.cgi?id=399633&action=review




--- Comment #29 from Dean Jackson <dino at apple.com> ---
Comment on attachment 399633
  --> https://bugs.webkit.org/attachment.cgi?id=399633
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=399633&action=review

Remember to not commit the change to the scheme.

> Source/WebCore/WebCore.xcodeproj/xcshareddata/xcschemes/WebCore.xcscheme:47
> +	 <PathRunnable
> +	    runnableDebuggingMode = "0"
> +	    BundleIdentifier = "org.webkit.MiniBrowser"
> +	    FilePath = "/Users/mmaxfield/Build/Products/Debug/MiniBrowser.app">
> +	 </PathRunnable>

oops

> Source/WebCore/platform/graphics/gpu/GPUDevice.cpp:118
> +	   if (descriptor.size.width > 8192 || descriptor.size.height > 8192) {

Please static const this max value.

> Source/WebCore/platform/graphics/gpu/GPUDevice.cpp:122
> +	   if (descriptor.size.depth > 2048) {

And this.

> Source/WebCore/platform/graphics/gpu/GPUDevice.cpp:128
> +	   if (descriptor.size.width > 2048 || descriptor.size.height > 2048 ||
descriptor.size.depth > 2048) {

And this.

Also, should we provide the maximum values in the error?