[webkit-reviews] review granted: [Bug 212026] [GTK] Allow gtk-doc and introspection in cross builds : [Attachment 399647] Patch

[bugzilla-daemon at webkit.org]

Adrian Perez <aperez at igalia.com> has granted Michael Catanzaro
<mcatanzaro at gnome.org>'s request for review:
Bug 212026: [GTK] Allow gtk-doc and introspection in cross builds
https://bugs.webkit.org/show_bug.cgi?id=212026

Attachment 399647: Patch

https://bugs.webkit.org/attachment.cgi?id=399647&action=review




--- Comment #2 from Adrian Perez <aperez at igalia.com> ---
Comment on attachment 399647
  --> https://bugs.webkit.org/attachment.cgi?id=399647
Patch

I think this is from before the times packagers figured out that they
could run gtk-doc and/or g-ir-scanner/g-ir-generate using qemu userspace
emulation to allow running code for the target platform when doing a
cross-compiled build. While that's a terrible hack and ideally GTK-Doc
and GI should support cross-compilation better, it's true that it is
no longer needed to forcibly disable these two options ��️

Let's land this.