[webkit-reviews] review granted: [Bug 205119] Remove certain headers when a redirect causes a request method change : [Attachment 399641] Patch

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Mon May 18 07:26:26 PDT 2020


youenn fablet <youennf at gmail.com> has granted Rob Buis <rbuis at igalia.com>'s
request for review:
Bug 205119: Remove certain headers when a redirect causes a request method
change
https://bugs.webkit.org/show_bug.cgi?id=205119

Attachment 399641: Patch

https://bugs.webkit.org/attachment.cgi?id=399641&action=review




--- Comment #13 from youenn fablet <youennf at gmail.com> ---
Comment on attachment 399641
  --> https://bugs.webkit.org/attachment.cgi?id=399641
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=399641&action=review

> Source/WebCore/platform/network/ResourceRequestBase.cpp:140
> +void ResourceRequestBase::redirectAsGETIfNeeded(ResourceRequest &newRequest,
const ResourceResponse& redirectResponse) const

Let's change this method so that newRequest iss 'this' and the redirectRequest
is passed as const ResourceRequest&.
And then we could write it as:
if (!shouldUseGet(redirectRequest, redirectResponse))
    return;

setHTTPMethod(...)
...


More information about the webkit-reviews mailing list