[webkit-reviews] review granted: [Bug 211978] Add a timeout monitor for JSC stress test : [Attachment 399544] Patch

[bugzilla-daemon at webkit.org]

Jonathan Bedard <jbedard at apple.com> has granted Zhifei Fang
<zhifei_fang at apple.com>'s request for review:
Bug 211978: Add a timeout monitor for JSC stress test
https://bugs.webkit.org/show_bug.cgi?id=211978

Attachment 399544: Patch

https://bugs.webkit.org/attachment.cgi?id=399544&action=review




--- Comment #4 from Jonathan Bedard <jbedard at apple.com> ---
Comment on attachment 399544
  --> https://bugs.webkit.org/attachment.cgi?id=399544
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=399544&action=review

> Tools/Scripts/webkitruby/jsc-stress-test-writer-default.rb:259
> +    echo "#{Shellwords.shellescape(@name)} is time out, killing by timeout
monitor"

Should be 'has timed out, killing with the timeout monitor'

> Tools/Scripts/webkitruby/jsc-stress-test-writer-default.rb:261
> +    sleep 5	# give a grace period

I don't think the comment here is particularly helpful.

> Tools/Scripts/webkitruby/jsc-stress-test-writer-default.rb:324
> +	       cmd = timeoutMonitorAddon

I feel like we need to replace this with Python in the near future....this
feels incredibly hackey.