[webkit-reviews] review granted: [Bug 211915] REGRESSION (r261493?): media/video-isplayingtoautomotiveheadunit.html is a flaky failure : [Attachment 399542] Patch
bugzilla-daemon at webkit.org
bugzilla-daemon at webkit.org
Mon May 18 06:45:44 PDT 2020
Daniel Bates <dbates at webkit.org> has granted Peng Liu <peng.liu6 at apple.com>'s
request for review:
Bug 211915: REGRESSION (r261493?):
media/video-isplayingtoautomotiveheadunit.html is a flaky failure
https://bugs.webkit.org/show_bug.cgi?id=211915
Attachment 399542: Patch
https://bugs.webkit.org/attachment.cgi?id=399542&action=review
--- Comment #5 from Daniel Bates <dbates at webkit.org> ---
Comment on attachment 399542
--> https://bugs.webkit.org/attachment.cgi?id=399542
Patch
View in context: https://bugs.webkit.org/attachment.cgi?id=399542&action=review
> LayoutTests/media/video-isplayingtoautomotiveheadunit.html:43
> + run('internals.setIsPlayingToAutomotiveHeadUnit(false)');
This is ok as is. No change needed. The optimal solution is for
WebKitTestRunner's/DumpRenderTree's resetToConsistentState or
resetInternalSettings or whatever that function is called to do this.
More information about the webkit-reviews
mailing list