[webkit-reviews] review granted: [Bug 209461] [css-grid] Grid layout unstable with percentage margin : [Attachment 399527] Patch

[bugzilla-daemon at webkit.org]

Manuel Rego Casasnovas <rego at igalia.com> has granted Oriol Brufau
<obrufau at igalia.com>'s request for review:
Bug 209461: [css-grid] Grid layout unstable with percentage margin
https://bugs.webkit.org/show_bug.cgi?id=209461

Attachment 399527: Patch

https://bugs.webkit.org/attachment.cgi?id=399527&action=review




--- Comment #5 from Manuel Rego Casasnovas <rego at igalia.com> ---
Comment on attachment 399527
  --> https://bugs.webkit.org/attachment.cgi?id=399527
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=399527&action=review

This looks good, I have a question inline but otherwise r=me.
Please clarify that before landing.

> Source/WebCore/rendering/GridTrackSizingAlgorithm.cpp:920
> +    GridTrackSizingDirection childBlockDirection =
GridLayoutFunctions::flowAwareDirectionForChild(*renderGrid(), child, ForRows);

Why you need this here and not before?