[webkit-reviews] review denied: [Bug 212006] [JSC] Silence unused-but-set-parameter warnings for older compilers : [Attachment 399614] Patch

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Sun May 17 20:50:19 PDT 2020

Mark Lam <mark.lam at apple.com> has denied Lauro Moura <lmoura at igalia.com>'s
request for review:
Bug 212006: [JSC] Silence unused-but-set-parameter warnings for older compilers

Attachment 399614: Patch


--- Comment #2 from Mark Lam <mark.lam at apple.com> ---
Comment on attachment 399614
  --> https://bugs.webkit.org/attachment.cgi?id=399614

View in context: https://bugs.webkit.org/attachment.cgi?id=399614&action=review

> Source/JavaScriptCore/jit/CCallHelpers.h:111
> +	       // Silence some older compilers (GCC up to 9.X) about unused but
set parameters.
> +	       (void)sources;
> +	       (void)destinations;

We have standard idiom for this: see uses of UNUSED_PARAM in the code.

More information about the webkit-reviews mailing list